Feat/signup rec iteration 6 #1656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed test on run #304 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| signup a newbie ninja > allows signup (with random test-strings) |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #1656 ↗︎
and to the self menu areas for clickability of the logout, and other menu items.
since it is currently not in use.
tchalvak
commented
May 31, 2024
| @@ -1 +1,2 @@ | |||
| <p>Your current level is {$player->level|escape}. Your current kills are {$player->kills|escape}.</p> | |||
| <p>Your current level is <strong class='level'>{$player->level|escape}</strong>. <br /> | |||
There was a problem hiding this comment.
This has been cherry-picked in to master elsewhere.
tchalvak
commented
May 31, 2024
deploy/templates/bath-house.tpl
Outdated
| @@ -32,7 +32,11 @@ | |||
| <ul id='duel-log' style='overflow-y: auto;max-height:20rem;'> | |||
| {foreach item="duel" from=$duels} | |||
| <li> | |||
| {include file="player-link.tpl" username=$duel.attacker id=$duel.attacker_id} has dueled {include file="player-link.tpl" username=$duel.defender id=$duel.defender_id} and {if $duel.won}won{else}lost{/if} for {$duel.killpoints} killpoints on {$duel.date} | |||
| {include file="player-link.tpl" username=$duel.attacker id=$duel.attacker_id} | |||
There was a problem hiding this comment.
This was cherry-picked in elsewhere.
|
I think most of this was cherry-picked elsewhere now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR:
Before
After
For Non-Hotfixes:
Attached Screenshot of my change:
Things that make review take longer:
(remove lines that do not apply to this PR)
Things that make review faster and easier:
(check box with an x where it applies)
Preview results in my branch at the url: